This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
Error: Already Piped FIX #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore which i think fixes this issue also https://github.com/libp2p/js-libp2p-switch/issues/235
harrshasri
changed the title
|
@diasdavid Can you accept this fix |
|
@diasdavid Do we need to update this package dependency in js-ipfs v28.2 to v28.3 |
|
@harrshasri note that secio was published as a patch version. The error you are seeing (already piped) is being fixed by #245 |
daviddias
reviewed
Apr 3, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "libp2p-switch", | |||
| "version": "0.37.3", | |||
| "version": "0.37.4", | |||
There was a problem hiding this comment.
ah crap. Please do not update the version manually, our release process does it.
There was a problem hiding this comment.
Oh Okay. Sorry. I'm a noob.
There was a problem hiding this comment.
no worries at all. Shame on me for not reviewing it properly :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore which i think fixes this issue also
https://github.com/libp2p/js-libp2p-switch/issues/235